Skip to content

fix: escape tags inside of <title> (upgrade html-dom-parser to 1.0.0) #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 27, 2020
Merged

fix: escape tags inside of <title> (upgrade html-dom-parser to 1.0.0) #203

merged 4 commits into from
Dec 27, 2020

Conversation

remarkablemark
Copy link
Owner

What is the motivation for this pull request?

fix: escape tags inside of <title>

Fixes #202

What is the current behavior?

Tags inside of <title> are not escaped.

What is the new behavior?

Tags inside of <title> are escaped by upgrading to html-dom-parser@1.0.0.

 html-dom-parser  0.5.0  →  1.0.0

Checklist:

  • Tests
  • Documentation

@remarkablemark remarkablemark added bug Something isn't working dependencies Pull requests that update a dependency file labels Dec 27, 2020
@remarkablemark remarkablemark self-assigned this Dec 27, 2020
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 7.23 KB (+0.84% 🔺) 145 ms (+0.84% 🔺) 89 ms (+0.55% 🔺) 233 ms

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 886e53d on fix/title into 6cd9a20 on master.

@remarkablemark remarkablemark merged commit f22d756 into master Dec 27, 2020
@remarkablemark remarkablemark deleted the fix/title branch December 27, 2020 23:07
@remarkablemark
Copy link
Owner Author

Published v1.1.1:

npm:

npm i html-react-parser@1.1.1

Yarn:

yarn add html-react-parser@1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@remarkablemark remarkablemark

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] tags inside of <title> are not parsed as text on Node.js
2 participants
@remarkablemark @coveralls