Fix case when style is empty string #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarkablemark
requested changes
Mar 11, 2018
There was a problem hiding this comment.
Like my comment in the other PR, do you mind amending the commit message because the conventional commit format is used when releasing and publishing the package:
fix(parser): fix case when style is empty string
| @@ -46,7 +46,7 @@ function attributesToProps(attributes) { | |||
| } | |||
|
|
|||
| // convert inline style to object | |||
| if (attributes.style) { | |||
| if (attributes.style != null) { | |||
There was a problem hiding this comment.
Just to confirm, are we not doing strict equality on purpose?
There was a problem hiding this comment.
Yes, if attributes.style is undefined or null this will return false in both cases (I think I've added corresponding unit tests), inspired by lodash'es isNil
There was a problem hiding this comment.
Gotcha thanks for clarifying
yuliya-ivaniukovich
force-pushed
the
empty-style-fix
branch
from
7e573c3 to
fa2a8b4
Compare
|
Amended comment as requested |
remarkablemark
approved these changes
Mar 27, 2018
d-lazarev
pushed a commit
to d-lazarev/html-react-parser
that referenced
this pull request
Apr 5, 2019
…tyle-fix Fix case when style is empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.