Fix boolean attributes parsing #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarkablemark
requested changes
Mar 11, 2018
There was a problem hiding this comment.
Thanks for creating the PR @yuliya-ivaniukovich
Everything looks great but do you mind amending your commit message because the format is used for the version bump and changelog update:
fix(parser): fix boolean attributes parsing
yuliya-ivaniukovich
force-pushed
the
bool-props-fix
branch
from
8e6b489 to
e478a44
Compare
|
Amended message as requested. |
remarkablemark
approved these changes
Mar 27, 2018
d-lazarev
pushed a commit
to d-lazarev/html-react-parser
that referenced
this pull request
Apr 5, 2019
…ops-fix Fix boolean attributes parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.