Skip to content

fix(index): export domhandler classes #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 25, 2022
Merged

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Dec 25, 2022

What is the motivation for this pull request?

fix(index): export domhandler classes

Fixes #777

What is the current behavior?

Only domhandler class Element is exported

What is the new behavior?

Export additional domhandler classes:

  • Comment
  • ProcessingInstruction
  • Text

Checklist:

Fixes #777

Export domhandler classes:
- Comment
- Node
- ProcessingInstruction
- Text
@remarkablemark remarkablemark added the bug Something isn't working label Dec 25, 2022
@remarkablemark remarkablemark self-assigned this Dec 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2022

Codecov Report

Merging #780 (7a9c207) into master (4c3f41b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #780   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          167       171    +4     
  Branches        57        57           
=========================================
+ Hits           167       171    +4     
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 10.27 KB (+0.06% 🔺) 206 ms (+0.06% 🔺) 52 ms (+168.66% 🔺) 257 ms

@remarkablemark remarkablemark merged commit c33f6c4 into master Dec 25, 2022
@remarkablemark remarkablemark deleted the fix/domhandler branch December 25, 2022 20:16
@remarkablemark
Copy link
Owner Author

Release 3.0.5:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Text from domhandler
2 participants