New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding options for `domParserOptions` #79

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@rntgspr

rntgspr commented Dec 3, 2018

Adding options for domParserOptions using Object.assign before send it directly to the parser itself;
Setting up a default value for domParserOptions;

Consider a possible refactoring, I am using github interface to update it.

I believe it closes #62

update:
I give up from this PR because we need a different solution to write raw strings on a React components. I believed to be logic to this repo do it, but actually it did not makes sense, crossing HTML/JSX/React Documentations.

@coveralls

This comment has been minimized.

coveralls commented Dec 3, 2018

Coverage Status

Coverage decreased (-0.7%) to 98.485% when pulling fc8b224 on rntgspr:master into bfe2023 on remarkablemark:master.

@remarkablemark

Thanks for creating the PR @rntgspr. I added a comment and could you also handle the tasks:

  • Run npm run lint:fix to make the CI build pass
  • Add tests
Show resolved Hide resolved index.js Outdated
Adding options for `domParserOptions`
Adding options for `domParserOptions` using Object.assign before send it directly to the parser itself;
Setting up a default value for `domParserOptions`;

Consider a possible refactoring, I am using github interface to update it.

update:
Now on keyboard, reafactoring made,
Thanks to @remarkablemark about the iE hint!
Tests added.
@remarkablemark

This comment has been minimized.

Owner

remarkablemark commented Dec 5, 2018

@rntgspr What is the warning that you get?

Show resolved Hide resolved CHANGELOG.md
Show resolved Hide resolved index.js
Show resolved Hide resolved index.js
Show resolved Hide resolved package.json
@remarkablemark

This comment has been minimized.

Owner

remarkablemark commented Dec 5, 2018

@rntgspr Did you close this PR intentionally? If so, let me know what I can do to help you get this merged in because I believe the feature here is useful

@rntgspr

This comment has been minimized.

rntgspr commented Dec 10, 2018

Yes,

It can be useful, but it no matches with all documentations together.

1- warnings from ReactJS (warnings, self explanatory);
2- self-close from JSX(it always open and closes custom self-closed tags, it don't works in all possible scenarios);
3- lowercase from HTML5(take a look on: Use Lower Case Element Names section);

best,
Gaspar

@remarkablemark

This comment has been minimized.

Owner

remarkablemark commented Dec 12, 2018

Thanks for the update @rntgspr. I appreciate the effort and I'll borrow some things from this PR to make as feature enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment