TypeScript error importing node:async_hooks

[Methuselah96]

Reproduction

1. Clone https://github.com/Methuselah96/react-router-tsc-error (this is just the Vite template with react-router installed and skipLibCheck set to false)
2. Run npm run build

System Info

System:
    OS: Windows 11 10.0.26100
    CPU: (20) x64 13th Gen Intel(R) Core(TM) i5-13500
    Memory: 6.43 GB / 31.65 GB
  Binaries:
    Node: 22.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 4.9.2 - C:\Program Files\nodejs\yarn.CMD
    npm: 10.9.2 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.15.9 - C:\Program Files\nodejs\pnpm.CMD
    bun: 1.1.0 - ~\.bun\bin\bun.EXE
  Browsers:
    Edge: Chromium (131.0.2903.70)
    Internet Explorer: 11.0.26100.1882
  npmPackages:
    react-router: ^7.7.0 => 7.7.0
    vite: ^7.0.4 => 7.0.5

Used Package Manager

npm

Expected Behavior

No type errors.

I am using react-router only for the browser, so I don't think I should have to install @types/node, since I'm not using Node.

Actual Behavior

Type errors:

node_modules/react-router/dist/development/browser-CcxeZJcQ.d.mts:1:35 - error TS2307: Cannot find module 'node:async_hooks' or its corresponding type declarations.

1 import { AsyncLocalStorage } from 'node:async_hooks';
                                    ~~~~~~~~~~~~~~~~~~

node_modules/react-router/dist/development/index.d.mts:15:8 - error TS2307: Cannot find module 'node:async_hooks' or its corresponding type declarations.

15 import 'node:async_hooks';
          ~~~~~~~~~~~~~~~~~~


Found 2 errors.

This is a new error as of 7.7.0

[brophdawg11]

Our recommendation is to keep skipLibCheck set to true - which is how we have our templates set up.

react-router@7.7.0 included RSC support (unstable) which leverages AsyncLocalStorage so that is a valid usage in our code even if you aren't leveraging that particular part of the library. Our code is type checked as part of our build process where @types/node is present so you can trust that our types are OK in node_modules.

If you need to set skipLibCheck:false, then I would install @types/node` as a dependency if you need to fix that error.

[Methuselah96]

Our recommendation is to keep skipLibCheck set to true - which is how we have our templates set up.

Setting skipLibCheck to true would cause us to miss other legitimate errors in other declaration files, so I'm not convinced that's a good solution. (We have skipLibCheck set to false in local development for the performance improvement, but then set it to true in CI to catch issues like these.)

If you need to set skipLibCheck:false, then I would install @types/node as a dependency if you need to fix that error.

We want to make sure we're not using Node types unintentionally, since it's not a Node project, so this also seems undesirable.

[brophdawg11]

to catch issues like these.

This is not really an issue though? React Router includes code that can run in a node environment, and our builds/types are valid against @types/node. You're non-node project isn't using that code, but that doesn't make it incorrect.

[Methuselah96]

I was just meaning to say that we set skipLibCheck to true to catch issues in declaration files, some of which are more severe than others. For example, sometimes we see declaration files importing a type that doesn't exist, which would cause that type to be typed as any.

I suppose it's up for debate whether or not this is a "real issue." Right now the types are claiming that a global variable named ___reactRouterServerStorage___ exists, which is a Node.js AsyncLocalStorage, which I assume is not accurate for non-Node projects?

[brophdawg11]

yeah that's only used for RSC projects

[Methuselah96]

Would you be open to a PR that prevents the ___reactRouterServerStorage___ variable from leaking out into the declaration file? Maybe something like this?

[markdalgleish]

@Methuselah96 Thanks for the PR. Once it's updated to point to dev rather than main, we can get this merged.

[github-actions]

🤖 Hello there,

We just published version 7.8.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 7.8.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!