1.0.0-rc1 Documentation for DynamicRouting incorrect

[jhchill666]

The documentation for 1.0.0-rc1 - DynamicRouting, incorrectly states the following signature is used for declaring async routes:

getComponents(callback) {
    require.ensure([], function (require) {
      callback(null, require('./components/Course'))
    })
  }

Looking at getComponents.js, the supplied arguments should be location then callback

....
} else if (route.getComponents) {
    route.getComponents(location, callback);
}
....

[ponty96]

yeah, thats true. I think that should be changed

[knowbody]

thank you @jamiehill. mind submitting a PR with a fix?

[jhchill666]

Sure thing ...

[ryanflorence]

closing in lieu of a pull request, github makes it really easy with the "edit" button on the page, thanks for helping out :)