[META] 3.0.0-alpha.1

[taion]

I'm sorry, I would have just gotten to these but I've been really slammed. This is just a list of what I'd like to resolve before cutting 3.0.0-pre.0.

• Put routes on context.router (and inject in withRouter)
• Move out ContextUtils into a separate library (I've already name-squatted react-context-subscriber)
• Figure out if we can avoid calling createRouterObject on both https://github.com/reactjs/react-router/blob/17a362556f49f780a585f7ef6fcbe79b4311307e/modules/Router.js#L86 and https://github.com/reactjs/react-router/blob/17a362556f49f780a585f7ef6fcbe79b4311307e/modules/Router.js#L94

[timdorr]

For the createRouterObject issue, why did we go with wrapping up location and params into router before putting it on context? As implemented, it seems pretty messy to me, particularly around the identity maintenance.

Here's the question I'm asking in my head: Do we need the location and params wrapped up into router somewhere where context isn't involved? It seems like either those values (or some form of state) is available whenever it gets passed around. So, we're moving them up higher in the composition, but with bad side-effects that make the code at that level less clear (because it's tied to effects in other parts of the code).

[taion]

We were maintaining the identity of the router object anyway, and it avoids doing something a lot messier to get context.router to update in <Link>.

We don't need those to be on router where context isn't involved, but it seems like less to keep track of if we don't have some weird rule that "props.router in a router context doesn't have params and location, but only context.router does".

[timdorr]

OK, not a huge deal then. I just see a new dep and start to pump the brakes at little bit.

Anyways, it should be fixed by #3446.

For putting route on context, we need a RouteContext don't we? (not the mixin)

Edit:

Put routes on context.router

Wait a tic, do you mean routes or route?

[taion]

routes, not route

I just want context.router and withRouter to be as symmetric as possible to route components, which all receive routes, location, and params.

[timdorr]

Threw that into #3446 for you.

[taion]

@timdorr Thanks. I'll take care of that last bit either tomorrow or Thursday. Sorry this has been taking so long.

[ayrton]

@taion if there's anything I can do to help, happy to lend a hand 😄

[taion]

I'll have some time to look at this today or tomorrow. Sorry for the delay.

[ayrton]

Not trying to rush you, just checking if any help is needed

[gaearon]

Can we release a prerelease before pulling that code out? It’s an implementation detail so we can do it later at an RC stage. I’m going to need that version for a workshop I’ll be running soon, so it would be great if we could get it out.

[taion]

I'll cut the prerelease today either way. Sorry it's taken so long.