Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for case sensitive routes #5435

Closed
apoh opened this issue Aug 16, 2017 · 1 comment
Closed

Support for case sensitive routes #5435

apoh opened this issue Aug 16, 2017 · 1 comment
Labels

Comments

@apoh
Copy link

apoh commented Aug 16, 2017

Currently Route handles paths in non case sensitive way. We want to add support for case sensitive paths.

Example:

   <Route sensitive path={"/example"} />
path location.pathname sensitive matches
/one /one false true
/one /One false true
/one /one true true
/one /One true false

By default sensitive could be false to keep the behaviour downward compatible.
We believe this can be easily implement since path-to-regex has a support for this option path to regex documentation.

One of the reasons for this feature is for example to avoid duplicate content that has negative impact on search engines.

Please let us know if you have any comments about this. We are thinking make a pull request for this feature.

@pshrmn
Copy link
Contributor

pshrmn commented Aug 16, 2017

I would recommend making that PR. That is the best way to get traction with a feature request. I think that it will require maybe 5 lines of code in the actual modules (plus you will need to write a number of tests).

@pshrmn pshrmn added the feature label Aug 16, 2017
@timdorr timdorr closed this as completed Aug 18, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants