Skip to content

Improving tests for URLStore #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2014
Merged

Improving tests for URLStore #100

merged 1 commit into from
Jul 22, 2014

Conversation

mzabriskie
Copy link
Contributor

Made a few improvements:

  • The test for URLStore.replace was calling URLStore.push
  • Added coverage for URLStore.back

mjackson added a commit that referenced this pull request Jul 22, 2014
@mjackson
Merge pull request #100 from mzabriskie/master
444f438 
Improving tests for URLStore
@mjackson mjackson merged commit 444f438 into remix-run:master Jul 22, 2014
@mjackson
Copy link
Member

@mzabriskie Thank you!

@ryanflorence
Copy link
Member

I <3 all my friends.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzabriskie @mjackson @ryanflorence