Skip to content

Conversation

landisdesign
Copy link
Contributor

After explaining how React Router uses response objects to replicate web standard behavior, it can be confusing why this suddenly stops working just by adding "defer" to the loader's return value. Thinking it through yields the answer (deferred data isn't handled by the response returning the HTML), but it seems like it would reduce the friction to add a little explanation.

After explaining how React Router uses response objects to replicate web standard behavior, it can be confusing why this suddenly stops working just by adding "defer" to the loader's return value. Thinking it through yields the answer (deferred data isn't handled by the response returning the HTML), but it seems like it would reduce the friction to add a little explanation.
@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2023

⚠️ No Changeset found

Latest commit: b1b2694

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 29, 2023

Hi @landisdesign,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 29, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title Add FAQ about using Response objects with defer docs(guides/deferred): add FAQ about using Response objects with defer Jan 30, 2023
@brophdawg11
Copy link
Contributor

Thanks! This type of question has come up before too where folks forget to call res.json(). I made a slight update so this new section in the docs can address both scenarios

@brophdawg11 brophdawg11 merged commit df97043 into remix-run:main Mar 3, 2023
@landisdesign
Copy link
Contributor Author

I like the change! I appreciate how it goes into making the loader more responsive to deferred responses. I think this could still benefit from a code example for the component, to illustrate how it now needs to manage the redirect rather than leaving it to the loader. I know that's what tripped me up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants