Skip to content

Conversation

vasanthk
Copy link
Contributor

@ryanflorence
Copy link
Member

thanks @vasanthk, mind updating this to latest master? The code isn't move around like it has been, then we'll merge this.

@vasanthk
Copy link
Contributor Author

@ryanflorence Updated it to the latest master. Does it look fine now?

@krzysiek1507
Copy link

@vasanthk
Copy link
Contributor Author

@krzysiek1507 Modified it too. Thanks :)

@gaearon
Copy link
Contributor

gaearon commented Jun 13, 2015

Can you squash into a single commit please?

@vasanthk
Copy link
Contributor Author

@gaearon Getting an 'error: could not apply' when I try to squash the commits. Wonder if few of my commits have become useless after a merge. Could you help me out with the squash?

@gaearon
Copy link
Contributor

gaearon commented Jun 13, 2015

@vasanthk

I usually do this:

git fetch upstream
git checkout mybranch
git merge upstream/master

# if necessary, resolve conflicts and git commit
# ...

git reset --soft upstream/master
git commit -am 'Some cool description for a single commit'
git push -f

Note that it's super important that you merge before resetting, and that the argument is the same master branch. Otherwise you risk messing up your local history.

@vasanthk
Copy link
Contributor Author

@gaearon That worked. Thanks 👍

gaearon added a commit that referenced this pull request Jun 14, 2015
getDOMNode() has been deprecated. Use React.findDOMNode() instead.
@gaearon gaearon merged commit ccfc65e into remix-run:master Jun 14, 2015
@gaearon
Copy link
Contributor

gaearon commented Jun 14, 2015

👍

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants