[changed] fallback to window.location for history #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `<Routes location=“history”/>` is used we now fall back to window.location for browsers that don’t support the HTML5 history API Rather than falling back to hash, falling back to window.location ensures urls are identical for all users, and sharing them will always work closes #50
|
thanks @spicyj, updated the branch |
|
lgtm |
|
then by all means, click the merge button |
|
okay fine. :) |
sophiebits
added a commit
that referenced
this pull request
Jul 27, 2014
[changed] fallback to window.location for history
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
<Routes location=“history”/>is usedwe now fall back to window.location for browsers
that don’t support the HTML5 history API
Rather than falling back to hash, falling back to
window.location ensures urls are identical for
all users, and sharing them will always work
closes #50