If query is a string, parse it first. #1312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently makePath accepts string queries. This commit allows them in isActive as well.
|
Which of [fixed], [changed], etc. should go to the commit subject (if any)? I'm not sure. |
|
This behavior is outside of the responsibilities of the router. Histories are responsible for parsing query strings, routers are responsible for stringifying queries (if they're not already). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently makePath accepts string queries. This commit allows them in isActive as well.
Will add a test a bit later. Please don't merge yet.
Also, docs will be updated after #1311 is merged.