Skip to content

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Aug 29, 2025

This PR adds same suggestion from remix-run/react-router-templates#143. This should only affects how server module change causes re-evaluation of modules in rsc environment. Previously, any change would clear rsc environment module graph entirely (except externalized module which is in node's own module cache). With import.meta.hot.accept, this can be minimized to be only the modules from "entry" to "changed module" via import chain.

Copy link

changeset-bot bot commented Aug 29, 2025

⚠️ No Changeset found

Latest commit: 2809549

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@hi-ogawa hi-ogawa marked this pull request as ready for review August 29, 2025 02:05
@markdalgleish
Copy link
Member

markdalgleish commented Aug 29, 2025

@hi-ogawa We don't need the changeset on this one because this feature hasn't officially been released yet.

This reverts commit e98e1b4.
@hi-ogawa
Copy link
Contributor Author

Ah, I was confused because your PR had changeset. This should be removed because it's on @react-router/dev?

@markdalgleish
Copy link
Member

Yep. I added a changeset because I also fixed a bug in our unstable RSC Data Mode which has been released.

@markdalgleish markdalgleish merged commit 074530d into remix-run:dev Aug 29, 2025
8 checks passed
@hi-ogawa hi-ogawa deleted the 08-29-fix_rsc_add_import.meta.hot.accept_to_rsc_entry branch August 29, 2025 09:42
Copy link
Contributor

github-actions bot commented Sep 9, 2025

🤖 Hello there,

We just published version 7.9.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.9.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants