-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
fix(rsc): add import.meta.hot.accept
to rsc entry
#14263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rsc): add import.meta.hot.accept
to rsc entry
#14263
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
@hi-ogawa We don't need the changeset on this one because this feature hasn't officially been released yet. |
This reverts commit e98e1b4.
Ah, I was confused because your PR had changeset. This should be removed because it's on |
Yep. I added a changeset because I also fixed a bug in our unstable RSC Data Mode which has been released. |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
This PR adds same suggestion from remix-run/react-router-templates#143. This should only affects how server module change causes re-evaluation of modules in rsc environment. Previously, any change would clear rsc environment module graph entirely (except externalized module which is in node's own module cache). With
import.meta.hot.accept
, this can be minimized to be only the modules from "entry" to "changed module" via import chain.