Skip to content

[fixed] correctly updates the window scroll position #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2015
Merged

[fixed] correctly updates the window scroll position #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions modules/ScrollManagementMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ var ScrollManagementMixin = {

if (locationState && this.props.shouldUpdateScrollPosition(this.state, prevState)) {
var { scrollX, scrollY } = locationState;

if (scrollX != null && scrollY != null)
this.props.updateScrollPosition(location.navigationType, scrollX, scrollY);
this.props.updateScrollPosition(location.navigationType, scrollX || 0, scrollY || 0);
}
}

Expand Down
2 changes: 1 addition & 1 deletion modules/__tests__/scrollManagement-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('Scroll management', function () {

Inbox = React.createClass({
render() {
return <p>This is the inbox.</p>;
return <p style={{padding: '100px 3000px 3000px 100px'}}>This is the inbox.</p>;
}
});

Expand Down