[added] onClick handler to <Link /> #178
Merged
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/components/Link.js
Outdated
There was a problem hiding this comment.
I think the code is pretty clear here, no need for the comment :)
|
@spicyj thumbs up? |
modules/components/Link.js
Outdated
There was a problem hiding this comment.
do we need to check if this exists first? Or maybe provide a default noop function?
There was a problem hiding this comment.
This might be a little clearer as:
var ret = this.props.onClick(event);
// `false` prevents default; `undefined` does not
if (ret === false) {
allowTransition = false;
}
and then just if (allowTransition) at the bottom; it wasn't clear to me on a first reading why you were comparing to false down there.
There was a problem hiding this comment.
I did the same thing, actually. 👍
|
Updated! Thanks for the feedback; should be a bit cleaner now |
|
can you squash and force push? would be nice to be just one commit |
|
sure, done |
ryanflorence
added a commit
that referenced
this pull request
Aug 8, 2014
[added] onClick handler to <Link />
There was a problem hiding this comment.
/facepalm I should have caught that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #173 for previous discussion.