Fix and add some documentation about query params #1928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to understand how to access query params. After some trial and error, I realized that they were located in `this.props.location.query`. The Upgrade Guide incorrectly placed them at `this.props.query`, so I'm updating it to refer to the correct location. Fixes remix-run#1915
I found it hard to find information about how to access query parameter values in the docs. Adding a short paragraph about it to the "Introduction" guide could help others avoid having to dig deeper for it.
knowbody
added a commit
that referenced
this pull request
Sep 14, 2015
Fix and add some documentation about query params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.