Update for history createLocation deprecation #2170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createLocation is now deprecated in history. This updates to the new instance method form provided by any history instance.
mjackson
added a commit
that referenced
this pull request
Oct 5, 2015
Update for history createLocation deprecation
|
Thank you, @timdorr ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2169 was just a docs tweak. This has some real meat. You shouldn't get some upstream deprecation warnings from
historywith this.The build is still failing on isActive because of be37196. The internal state isn't being populated initially by
useRouteswhen usingmatch. I'll see if I can get to that one too.