Skip to content

Conversation

chiedo
Copy link

@chiedo chiedo commented Oct 14, 2015

I put together some updated testing docs for React-router 1.x.

There wasn't much to write as testing should "just work" with react-router 1.x but mainly this doc helps those upgrading from prior testing setups.

As I do more testing and run into issues, I can add more to the docs.

Re issue #2149

@chiedo chiedo changed the title Updated testing docs re issue #2149 Updated testing docs re issue Oct 14, 2015
@chiedo chiedo changed the title Updated testing docs re issue Updated testing docs for 1.x Oct 14, 2015
@chiedo
Copy link
Author

chiedo commented Oct 14, 2015

I placed the testing docs at the same location as the old testing docs so that the links already existing scattered through blogposts and forums will still work.

@knowbody
Copy link
Contributor

Very cool, thanks for that, mind adding an example to this guide as well?

@chiedojohn also maybe worth mentioning babel-jest and the config with webpack, what do you think?

@chiedo
Copy link
Author

chiedo commented Oct 14, 2015

I think that's a good call! @knowbody

I mentioned babel-jest. I don't use webpack though so maybe someone else could modify submit a PR for that portion?

In regards to the example. Do you think I should add that to the examples directory and link to it? Or just create the example in testing.md?

@knowbody
Copy link
Contributor

Cool, I fill the gap with webpack.

The example just put it in the bottom, something like:

Example:

some code

and this is how you can test it:

some code

@chiedo
Copy link
Author

chiedo commented Oct 14, 2015

Example added @knowbody

@knowbody
Copy link
Contributor

awesome, thank you!
one last thing can you squash the commits? and then I'll merge

Adding documentation for testing react-router with jest.
@chiedo
Copy link
Author

chiedo commented Oct 14, 2015

Squashed!

knowbody added a commit that referenced this pull request Oct 14, 2015
Updated testing docs for 1.x
@knowbody knowbody merged commit 7f2d1a3 into remix-run:master Oct 14, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants