[changed] Preventing transition from onClick #2307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with React v0.14, don't prevent the transition if the onClick handler returns false.
|
thanks @taion |
knowbody
added a commit
that referenced
this pull request
Oct 18, 2015
[changed] Preventing transition from onClick
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with React v0.14, don't prevent the transition if the onClick handler returns false.
Closes #2219
I added a basic test case to cover the default being prevented. Also reworded the IndexLink part of the upgrade guide slightly because it was a bit confusing - can split that out into a separate PR if desired though.