Skip to content

[changed] <Link/>s to take params property #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2014
Merged

[changed] <Link/>s to take params property #231

merged 1 commit into from
Aug 26, 2014

Conversation

ryanflorence
Copy link
Member

  • old behavior is maintained, but logs a
    deprecation warning
  • instead of passing in properties to fill in
    the dynamic segments, we just take it from the
    params object

closes #217

@ryanflorence ryanflorence mentioned this pull request Aug 26, 2014
Closed
@mjackson
Copy link
Member

I love <Link params={user}>. So clean! 👯

@mjackson
Copy link
Member

Can you rebase so we can merge cleanly?

@ryanflorence
Copy link
Member Author

yeah, I expected this

@ryanflorence
[changed] <Link/>s to take params property
8d2f3ed 
- old behavior is maintained, but logs a
  deprecation warning

- instead of passing in properties to fill in
  the dynamic segments, we just take it from the
  params object

closes #217
@ryanflorence
Copy link
Member Author

(passing in params={user} is pretty nice)

@ryanflorence
Copy link
Member Author

Also, when we remove the backwards compat in v1, we can remove a bunch of code from Link.

@paulstatezny
Copy link

👍 👍 Glad to see this change, thanks!

mjackson added a commit that referenced this pull request Aug 26, 2014
@mjackson
Merge pull request #231 from rackt/link-params
c81b55d 
[changed] `<Link/>`s to take params property
@mjackson mjackson merged commit c81b55d into master Aug 26, 2014
@mjackson mjackson deleted the link-params branch August 29, 2014 21:58
@zpao
Copy link

zpao commented Sep 1, 2014

Very happy to see this, I'm looking forward to it being the only way so my issue from #217 (comment) will be resolved :) (I'll probably just switch to using classes instead)

@ryanflorence
Copy link
Member Author

I'd like to remove the backwards compat in 0.7.0, so it should be soon :)

Sent from my iPhone

On Aug 31, 2014, at 6:35 PM, Paul O’Shannessy notifications@github.com wrote:

Very happy to see this, I'm looking forward to it being the only way so my issue from #217 (comment) will be resolved :) (I'll probably just switch to using classes instead)

—
Reply to this email directly or view it on GitHub.

ntdb added a commit to ntdb/react-router that referenced this pull request May 14, 2015
@ntdb
Update overview.md
37cf332 
Document the `<Link />` functionality added in remix-run#231
@ntdb ntdb mentioned this pull request May 14, 2015
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

paramsAreActive returns false if custom Link props are used.
5 participants
@ryanflorence @mjackson @paulstatezny @zpao @justinbelcher