Skip to content

Fix prop types on route components #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2015
Merged

Fix prop types on route components #2470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/IndexRoute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import React, { Component } from 'react'
import { createRouteFromReactElement } from './RouteUtils'
import { component, components, falsy } from './PropTypes'

const { bool, func } = React.PropTypes
const { func } = React.PropTypes

/**
* An <IndexRoute> is used to specify its parent's <Route indexRoute> in
Expand All @@ -26,9 +26,9 @@ class IndexRoute extends Component {

static propTypes = {
path: falsy,
ignoreScrollBehavior: bool,
component,
components,
getComponent: func,
getComponents: func
}

Expand Down
4 changes: 2 additions & 2 deletions modules/Route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React, { Component } from 'react'
import { createRouteFromReactElement } from './RouteUtils'
import { component, components } from './PropTypes'

const { string, bool, func } = React.PropTypes
const { string, func } = React.PropTypes

/**
* A <Route> is used to declare which components are rendered to the
Expand All @@ -21,9 +21,9 @@ class Route extends Component {

static propTypes = {
path: string,
ignoreScrollBehavior: bool,
component,
components,
getComponent: func,
getComponents: func
}

Expand Down