Update our tested browsers #2869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chrome 39 is sorta special since it's what Travis uses. If we have something that's broken in Chrome 39, we're likely to cause pain to our users who use Travis for their CI. |
|
What if we ran against the installed version of Chrome, rather than via BrowserStack? That way we stay in lockstep if Travis ever updates their build environment again (no idea what the holdup is. It's been 8 months...) |
|
Sounds like a good idea to me. @mjackson, any thoughts? Maybe we can configure this with |
|
I'll just make the BS config not overwrite the non-BS config. Should work fine. |
timdorr
force-pushed
the
upstack
branch
3 times, most recently
from
11f20d2 to
295b098
Compare
|
Might be worth updating rackt/history as well, then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox and Chrome were really old and auto-update now.
Also, iOS 9 and 8 distribution is high, so they should be tested too. Also bumped up Safari and used Windows 10 where possible.