Prevent infinite warning loops. #3031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent routerWarning from importing itself.
|
You're getting this because of a webpack misconfiguration. See #2892. That said, maybe we should merge this anyway – it's pretty low-cost and maybe saves users some pain. |
|
Ah, thanks for the clarity! I followed your trail to the stackoverflow answer. Happy to leave this open for you to merge at your discretion. |
|
I'm fine with merging this in. Thanks, @karenliu1! |
timdorr
added a commit
that referenced
this pull request
Feb 4, 2016
Prevent infinite warning loops.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent routerWarning from importing itself.
This was causing a "maximum call stack size exceeded" error for me (even when there is no warning --
falseToWarnin warning.js set totrue)Any thoughts?