Skip to content

Add order hints to lifecycle hook docs #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2016
Merged

Add order hints to lifecycle hook docs #3278

merged 1 commit into from
Apr 11, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented Apr 11, 2016

Fixes #3276

@taion taion mentioned this pull request Apr 11, 2016
Closed
@timdorr
Copy link
Member

timdorr commented Apr 11, 2016

Did you want to add any thing noting that's the order they will execute in?

@taion
Copy link
Contributor Author

taion commented Apr 11, 2016

That's exactly what this adds, no?

@timdorr
Copy link
Member

timdorr commented Apr 11, 2016

I mean something like "The number next to the lifecycle method is the order in which it will execute."

@taion
Copy link
Contributor Author

taion commented Apr 11, 2016

I don't see a good place to add that aside. Let's hope that this is good enough for now, and revise if there's further confusion.

@taion taion merged commit dd22bbe into remix-run:master Apr 11, 2016
@taion taion deleted the backport-lifecycle-hook-order branch April 11, 2016 16:38
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @timdorr