Add .DS_Store and node_modules to .gitignore

[gaearon]

No description provided.

[bobeagan]

meh on this. Those things belong in your local, global ignore. I prefer to keep a repo's gitignore specific to files generated, or directly related, to the repo. https://help.github.com/articles/ignoring-files#create-a-global-gitignore

[gaearon]

OK, but I accidentally added a DS_Store in another PR so I suppose we can delete it?
I can amend this PR to just get rid of it if you'd like.

[bobeagan]

I'd vote to just remove the file and be more observant of the files being added in PRs in the future by the merging user. If nobody else has a preference for keeping these things out of the list, then they can be added but it can start to get silly if you start adding IDE workspace files and other similar things.

[gaearon]

Yeah I totally understand that. Sorry. I updated the PR.

[yocontra]

@bobeagan What happens when you have another repo where you want to check in node_modules, but it is in your global gitignore? This doesn't seem contributor-friendly

[bobeagan]

@contra assuming that you ignored node_modules in your global, you can just explicitly not ignore it in the repo that you want it committed to. I did a quick check with one of my sublime project file global exclusions and added !*.sublime-project in my repo's .gitignore and it showed a file that was ready to be added. For something like node_modules I think that walks the line of being something that you can make a case for specifying in the repo's gitgnore (either for or against including it) per the repo owner's preference.

And I mean, if you change a single file and go to commit and see that you have 8129123 files being added you might consider that you modify your commit to manually exclude rather than just git adding everything blindly.