Skip to content

Fix example in README.md #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2016
Merged

Fix example in README.md #3419

merged 1 commit into from
Apr 30, 2016

Conversation

nolman
Copy link
Contributor

@nolman nolman commented Apr 30, 2016

Thanks for the explanation in #3418 @taion, what do you think about making the example a bit more explicit?

@taion
Copy link
Contributor

taion commented Apr 30, 2016

That's fine. Can you take out the // etc? It looks like everything is declared now.

@nolman
Copy link
Contributor Author

nolman commented Apr 30, 2016

Updated!

@taion taion merged commit b51d6ce into remix-run:master Apr 30, 2016
@taion
Copy link
Contributor

taion commented Apr 30, 2016

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nolman @taion