add note about possible use case for memoryHistory #3693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While developing a widget which is meant to be embedded into websites via an iframe, we noticed `history` taking over the parent page’s back/forward button (not a bug, just the way browser history works). We were able to isolate the routing to the widget by using `memoryHistory`. This PR just adds a tiny note that `createMemoryHistory` can be useful for a case like that.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing a widget which is meant to be embedded into websites
via an iframe, we noticed
historytaking over the parent page’sback/forward button (not a bug, just the way browser history works). We
were able to isolate the routing to the widget by using
memoryHistory.This PR just adds a tiny note that
createMemoryHistorycan be usefulfor a case like that.