Readme: Add root path to Route component #3724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just getting started with React-Router, but thought it was a little unclear that the root URL isn't specified in the Route that renders the App component. While /groups and /users will still render correctly, navigating to the root URL '/' will give an error.
|
Hey @leighsn, thanks for the PR! Looks like it's needed in the example below that for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just getting started with React-Router, but thought it was a little unclear that the root URL isn't specified in the
Routethat renders theAppcomponent. While/groupsand/userswill still render correctly, navigating to the root URL '/' will give an error.