Fix basename support #3858
Merged
Fix basename support #3858
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdorr
force-pushed
the
you-so-basic
branch
from
65cf1a2 to
c8a7dbb
Compare
Maybe open a new issue on that? |
|
That's covered by #3839. We need complete basename coverage. This just handles display, not passing that off to the history properly (and this is a quick fix version to start). |
|
Just FYI @timdorr, I'm gonna do an audit of how we're handling paths throughout the code in v4 today. A few things are inconsistent w the history library. |
|
Sounds good, since this is incomplete anyways :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3839
Uses @chentsulin's code from #3843
Basenames are handled by the history, but not by the stuff that actually displays URLs. This fixes things so rendered hrefs include the basename.
Note: This is broken as-is, as we need to strip the basename from the location pushed to history too.