Skip to content

Reserve className param #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2014
Merged

Reserve className param #53

merged 1 commit into from
Jun 27, 2014

Conversation

litek
Copy link

@litek litek commented Jun 27, 2014

When you set className on a Link instance, isActive is never true since it is included in the route comparison.

@ryanflorence
Copy link
Member

does this allow <Link className="foo"/> to become <a class="foo active"/> ?

@litek
Copy link
Author

litek commented Jun 27, 2014

Yeah, class="foo" when state.isActive is false, and class="foo active" when state.isActive is true

mjackson added a commit that referenced this pull request Jun 27, 2014
@mjackson
Merge pull request #53 from litek/master
c596293 
Reserve className param
@mjackson mjackson merged commit c596293 into remix-run:master Jun 27, 2014
@mjackson
Copy link
Member

Thanks @litek!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@litek @ryanflorence @mjackson