failing test for willTransitionFrom #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Man, what a tricky problem to track down. Thanks @nicib83 ! |
mjackson
added a commit
that referenced
this pull request
Jan 16, 2015
failing test for willTransitionFrom
brophdawg11
pushed a commit
that referenced
this pull request
Mar 27, 2024
Since react is loaded (in react-router-dom) before the NODE_ENV is set, but react-dom is loaded after NODE_ENV is set, so react is resolved to the development version, but react-dom is resolved to the production version. fix #632
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing test for #627