-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[added] router.replaceRoutes(children) #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Don't know what's failing Travis but locally tests run fine. |
f502720
to
4daadb0
Compare
Note: I slightly tweaked this PR to include |
4daadb0
to
97d1c8b
Compare
This still doesn't quite work as desired. We talked with @mjackson about this and maybe it's worth extracting either some parts of The scenario I need to support is following:
Right now, In this PR, I tried to fix this with |
97d1c8b
to
314b607
Compare
Changed the code to add |
+1. This seems to be what I'm looking for. Can't wait to try it out. |
314b607
to
2ac2510
Compare
Rebased on top of current master. Can we please get this in? |
@gaearon This looks great. Thank you :) |
[added] router.replaceRoutes(children)
YEAAH |
Supersedes #606, that's the only missing piece. Let me know if you want tests for this; I'm not sure where to put them because there are not tests for
addRoutes
either. But this has been working for me for a few weeks so I don't think it's problematic.