[fixed] Double slash in href when parent route has optional trailing sla... #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slash When a parent route of a child route has an optional trailing slash, the generated path for the child route will have two slashes in a row. Fix the trailing slash matcher pattern to account for this case. This bug occurs when calling `Path.injectParams(pattern, params)` to generate a path. The `pattern` for the path of a child route whose parent has an optional trailing slash looks something like `parent/?/child`. If we just replace `/?` with `/` we end up with `parent//child`, so we need to replace `/?/` with `/`. This fixes issue remix-run#768.
ryanflorence
added a commit
that referenced
this pull request
Feb 6, 2015
[fixed] Double slash in href when parent route has optional trailing sla...
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...sh
When a parent route of a child route has an optional trailing slash, the
generated path for the child route will have two slashes in a row. Fix
the trailing slash matcher pattern to account for this case.
This bug occurs when calling
Path.injectParams(pattern, params)togenerate a path. The
patternfor the path of a child route whoseparent has an optional trailing slash looks something like
parent/?/child. If we just replace/?with/we end up withparent//child, so we need to replace/?/with/.This fixes issue #768.