[fixed] Use more correct children invariant #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseywebdev
force-pushed
the
fix-invariant
branch
from
9b09231 to
585d8ec
Compare
caseywebdev
changed the title
|
Excellent. Thanks @caseywebdev ! |
mjackson
added a commit
that referenced
this pull request
Feb 13, 2015
[fixed] Use more correct children invariant
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation
<NotFoundRoute {...props}>{[]}</NotFoundRoute>fails, but clearly there are no children. This uses a more accurate check to determine whether there are actually component children.