-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
fix: generating path when passed only slash and star #9174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generating path when passed only slash and star #9174
Conversation
|
Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Thanks @KostiantynPopovych! I made a minor update to ensure we were always leaving slashes untouched and added some additional test cases. I'll get this merged once CI passes! |
Fix for #8883, a bit changed the logic of
generatePath
function, added handling of this particular edge case.