Skip to content

Conversation

KostiantynPopovych
Copy link

Fix for #8883, a bit changed the logic of generatePath function, added handling of this particular edge case.

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2022

⚠️ No Changeset found

Latest commit: 2a3ffcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 20, 2022

Hi @KostiantynPopovych,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 20, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr timdorr requested a review from brophdawg11 August 26, 2022 20:35
@brophdawg11
Copy link
Contributor

Thanks @KostiantynPopovych! I made a minor update to ensure we were always leaving slashes untouched and added some additional test cases. I'll get this merged once CI passes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: generatePath don't distinguish between absolute '/*' and relative '*'
2 participants