Skip to content

Conversation

infoxicator
Copy link
Contributor

Sorry this was my bad
Screenshot 2022-08-23 at 09 57 42

I thought you could highlight both added and removed lines but that doesn't seem to be the case so reverting to the original.

The reason I wanted to highlight the removal of
import App from "./App"; is because after removing all the files in the previous step the build will be broken because it can find that file. A savvy dev will figure it out but wanted to be explicit 👍

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

⚠️ No Changeset found

Latest commit: 5ccd47e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11
Copy link
Contributor

Thanks!

@brophdawg11 brophdawg11 merged commit e610a24 into remix-run:dev Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants