Skip to content

Conversation

CanRau
Copy link
Contributor

@CanRau CanRau commented Sep 3, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2022

⚠️ No Changeset found

Latest commit: 58b0791

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 3, 2022

Hi @CanRau,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 3, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@CanRau
Copy link
Contributor Author

CanRau commented Sep 3, 2022

Also I think an import for <Team/> is missing

import * as React from "react";
import * as ReactDOM from "react-dom";
import { DataBrowserRouter } from "react-router-dom";
import Root from "./routes/root";

ReactDOM.render(
  <DataBrowserRouter>
    <Route element={<Root />} loader={Root.loader}>
      <Route path="team" element={<Team />} loader={Team.loader}>
    </Route>
  </DataBrowserRouter>,
  root
);

@brophdawg11
Copy link
Contributor

Thanks @CanRau! Do you want to also add import Team from "./routes/team"; in this PR too and we can get it merged?

@CanRau
Copy link
Contributor Author

CanRau commented Sep 6, 2022

Done 🤝

@brophdawg11 brophdawg11 merged commit 29a3bca into remix-run:dev Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants