fix: prevent aborted defer values from starting a suspense render loop #9226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a01fec The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Sep 8, 2022
| } | ||
|
|
||
| function AwaitCounter({ data }) { | ||
| awaitRenderCount++; |
There was a problem hiding this comment.
Leveraging this to assert that we aren't continually re-rendering during the transition that triggered the abort
brophdawg11
commented
Sep 8, 2022
| href=\\"/bar\\" | ||
| > | ||
| Link to Bar | ||
| </a> |
There was a problem hiding this comment.
Shrunk the area of the DOM we were asserting in existing tests since I added a new link to /baz
brophdawg11
commented
Sep 8, 2022
| `); | ||
| // 2 more renders by now - once for the navigation and once for the | ||
| // promise abort rejection | ||
| expect(getAwaitRenderCount()).toBe(3); |
There was a problem hiding this comment.
When the loop is present this goes much higher than 3
jacob-ebey
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to send the
AbortedDeferredErrorthrough theTrackedPromisein_errorsoAwaitcan throw a never-resolving promise toSuspenseto freeze the UI. Otherwise, we end up throwing an already-rejected promise toSuspense, which sends it right back down toAwait. React does break out of this loop as soon as the next load or navigation finishes, but it's busted during the transition