Skip to content

Empty query string ("/?") causes route match to fail #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2015
Merged

Empty query string ("/?") causes route match to fail #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57860c6
Reproduce issue with empty query string.
benjie Mar 10, 2015
59c28de
[fixed] Empty query string now routes correctly
benjie Mar 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/PathUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var qs = require('qs');
var paramCompileMatcher = /:([a-zA-Z_$][a-zA-Z0-9_$]*)|[*.()\[\]\\+|{}^$]/g;
var paramInjectMatcher = /:([a-zA-Z_$][a-zA-Z0-9_$?]*[?]?)|[*]/g;
var paramInjectTrailingSlashMatcher = /\/\/\?|\/\?\/|\/\?/g;
var queryMatcher = /\?(.+)/;
var queryMatcher = /\?(.*)$/;

var _compiledPatterns = {};

Expand Down
9 changes: 9 additions & 0 deletions modules/__tests__/Router-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,15 @@ describe('Router', function () {
});
});

it('renders with empty query string', function (done) {
var routes = <Route handler={Foo} path='/'/>;
Router.run(routes, '/?', function (Handler, state) {
var html = React.renderToString(<Handler />);
expect(html).toMatch(/Foo/);
done();
});
});

it('executes transition hooks when only the query changes', function (done) {
var fromKnifeCalled = false;
var fromSpoonCalled = false;
Expand Down