Skip to content

activeRoute needs to support multiple children and needs to always return a function. #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

activeRoute needs to support multiple children and needs to always return a function. #94

wants to merge 2 commits into from

Conversation

benjohnson
Copy link
Contributor

  • activeRoute should be a function returning null when no route.
  • activeRoute actually needs to support multiple children.

Sigh

@mjackson
Copy link
Member

Let's leave out 412290b since @luigy fixed it in #93.

@benjohnson
Copy link
Contributor Author

Yep, pushing a new PR.

@benjohnson benjohnson closed this Jul 18, 2014
@benjohnson benjohnson deleted the fix-stupidity branch July 18, 2014 20:21
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjohnson @mjackson