refactor: remove redundant not found error handling from users service and controller

Author: kastov

src/modules/users/controllers/users.controller.ts

@@ -383,9 +383,6 @@ export class UsersController {
         };
     }
 
-    @ApiNotFoundResponse({
-        description: 'Users not found',
-    })
     @ApiOkResponse({
         type: GetUserByTelegramIdResponseDto,
         description: 'Users fetched successfully',
@@ -413,9 +410,6 @@ export class UsersController {
         };
     }
 
-    @ApiNotFoundResponse({
-        description: 'Users not found',
-    })
     @ApiOkResponse({
         type: GetUserByEmailResponseDto,
         description: 'Users fetched successfully',
@@ -443,9 +437,6 @@ export class UsersController {
         };
     }
 
-    @ApiNotFoundResponse({
-        description: 'Users not found',
-    })
     @ApiOkResponse({
         type: GetUserByTagResponseDto,
         description: 'Users fetched successfully',

src/modules/users/users.service.ts

@@ -361,8 +361,6 @@ export class UsersService {
                 tag: dto.tag || undefined,
             });
 
-            if (!result || result.length === 0) return fail(ERRORS.USERS_NOT_FOUND);
-
             return ok(result);
         } catch (error) {
             this.logger.error(error);