Skip to content

Conversation

ollyd
Copy link
Collaborator

@ollyd ollyd commented Oct 2, 2025

Currently when a checkbox of type ["boolean", "null"] is included in a schema it does not apply the correct values. When it's checked nothing will be sent to the API, and when it is unchecked null will be sent rather than false.

This PR corrects that behaviour so that:

  • checked -> true
  • unchecked -> false

Link to corresponding MR.

Toggle screenshots Screenshot 2025-10-02 at 11 00 14 am Screenshot 2025-10-02 at 11 00 08 am

@ollyd ollyd self-assigned this Oct 2, 2025
@ollyd ollyd added the bug Something isn't working label Oct 2, 2025
@ollyd ollyd marked this pull request as ready for review October 2, 2025 01:08
@ollyd ollyd requested review from brennj and dragidavid October 2, 2025 01:09
@brennj
Copy link
Collaborator

brennj commented Oct 3, 2025

Easy peasy, thanks for jumping on this Olly

@ollyd ollyd merged commit 1c3d73e into main Oct 6, 2025
5 checks passed
@ollyd ollyd deleted the rmt-1732-support-checkbox-boolean branch October 6, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants