Skip to content

fix(checkbox): Support optional boolean type #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

fix(checkbox): Support optional boolean type #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/field/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function addCheckboxAttributes(inputType: string, field: Field, schema: NonBoole
field.checkboxValue = schema.const

// However, if the schema type is boolean, we should set the valid value as `true`
if (schema.type === 'boolean') {
if (Array.isArray(schema.type) ? schema.type.includes('boolean') : schema.type === 'boolean') {
field.checkboxValue = true
}
}
Expand Down
12 changes: 12 additions & 0 deletions test/fields.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,6 +686,18 @@ describe('fields', () => {
expect(field?.checkboxValue).toBe(true)
})

it('uses checkbox input for boolean/null type array with boolean const value', () => {
const booleanNullSchema = {
'x-jsf-presentation': {
inputType: 'checkbox' as const,
},
'type': ['boolean', 'null'],
}
const field = buildFieldSchema(booleanNullSchema, 'test')
expect(field?.inputType).toBe('checkbox')
expect(field?.checkboxValue).toBe(true)
})

// Skipping these tests until we have group-array support
describe('array type inputs', () => {
it('uses group-array when items has properties', () => {
Expand Down