feat: filter None values from inputs before API requests #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR filters out None-valued inputs from all prediction and training creation methods before making API requests. This preserves legacy behavior and prevents potential API errors when users pass None values. Changes: - Add filter_none_values() utility function to recursively remove None values from dictionaries - Update encode_json() and async_encode_json() to filter None values when processing dicts - Apply filtering to deployments.predictions.create() and trainings.create() methods - Add comprehensive test suite for None filtering functionality Fixes https://linear.app/replicate/issue/DP-737
zeke
requested review from
aron,
dgellow,
jharrell,
mattrothenberg and
michaeldwan
|
Red herring. Closing. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: Moving this back to draft pending an internal discussion about whether this change is actually needed.
This PR filters out None-valued inputs from all prediction and training creation methods before making API requests.
Changes
filter_none_values()utility function to recursively remove None values from dictionariesencode_json()andasync_encode_json()to filter None values when processing dictsdeployments.predictions.create()andtrainings.create()methodsExample
Before:
After:
This preserves the legacy behavior where None-valued inputs are automatically removed before making API requests, preventing potential API errors.
Fixes https://linear.app/replicate/issue/DP-737