Glossary: "Read more" goes back to the current page instead of the documentation page

[fbg-si]

Summary

When a glossary term is opened by clicking its link in a page, the "Read more" link in the overlay doesn't open the documentation page. The browser goes back to the page I came from instead.

Environment

• Wiki.js 3.0.2, Docker image ghcr.io/requarks/wiki:3.0.2
• Same code in 3.1.0 and on scarlett
• Browser: Microsoft Edge 156.0.4314.58 (Chromium 156.0.8078.80), Windows

Steps to reproduce

1. Give a term a documentation page, e.g. /docs/target.
2. Open a page where the term is auto-linked and click it. The URL becomes ?glossary=Term.
3. Click "Read more" in the overlay.

Observed

I'm back on the page from step 2, with the overlay closed. /docs/target never opens, although hovering "Read more" shows the right URL.

Opening the overlay straight from the URL (pasting ?glossary=Term) works, so it only happens when the overlay was opened by a click.

Expected

/docs/target opens.

Likely cause

In frontend/src/components/GlossaryOverlay.vue, openDocumentation() calls close(), then router.push(href). When the overlay was opened by a click, close() calls router.back(). That one is async and lands after the push, so it wins.

function openDocumentation() {
  const href = documentationHref.value
  close()            // router.back() when the overlay was opened by a click
  router.push(href)  // overridden by the back navigation
}

Suggested fix

Skipping close() there seems enough, since leaving the page closes the overlay anyway:

function openDocumentation() {
  const href = documentationHref.value
  guardUnsaved(() => {
    siteStore.$patch({ overlay: '' })
    router.push(href)
  })
}

Workaround

A capture-phase click listener in the theme's head HTML that does a plain location.assign() on that link. With it, "Read more" opens the documentation page as expected, which also confirms the cause above.

[NGPixel]

Fixed via de28419. Will land in next release.