Skip to content

Commit b309d1b

Browse files
committed
Make sure our pre-built binaries has the nasm feature-flag enabled
1 parent 6b8b8e8 commit b309d1b

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

.github/workflows/contrib_rerun_py.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
--locked \
6666
-p rerun-cli \
6767
--no-default-features \
68-
--features native_viewer,web_viewer \
68+
--features release \
6969
--release \
7070
--target x86_64-unknown-linux-gnu
7171

.github/workflows/reusable_build_and_upload_rerun_cli.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ jobs:
180180
--locked \
181181
-p rerun-cli \
182182
--no-default-features \
183-
--features native_viewer,web_viewer \
183+
--features release \
184184
--release \
185185
--target ${{ needs.set-config.outputs.TARGET }}
186186

crates/top/rerun-cli/Cargo.toml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,16 @@ path = "src/bin/rerun.rs"
3737
doc = false
3838

3939
[features]
40-
# The default is what the user gets when they call `cargo install rerun-cli --locked`,
41-
# so wer have all the bells and wistles here
40+
## The default is what the user gets when they call `cargo install rerun-cli --locked`,
41+
## so we have all the bells and wistles here, except those that may require extra tools
42+
## (like "nasm").
43+
## That is: `cargo install rerun-cli --locked` should work for _everyone_.
4244
default = ["native_viewer", "web_viewer"]
4345

46+
## The features we enable when we build the pre-built binaries during our releases.
47+
## This may enable features that require extra build tools that not everyone heas.
48+
release = ["default", "nasm"]
49+
4450
## Enable faster native video decoding with assembly.
4551
## You need to install [nasm](https://nasm.us/) to compile with this feature.
4652
nasm = ["rerun/nasm"]

0 commit comments

Comments
 (0)