Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown heading levels all have the same font size #3612

Closed
roym899 opened this issue Oct 3, 2023 · 5 comments · Fixed by lampsitter/egui_commonmark#20 or #4178
Closed

Markdown heading levels all have the same font size #3612

roym899 opened this issue Oct 3, 2023 · 5 comments · Fixed by lampsitter/egui_commonmark#20 or #4178
Labels
😤 annoying Something in the UI / SDK is annoying to use egui Requires egui/eframe work ui concerns graphical user interface
Milestone
Triage

Comments

@roym899
Copy link
Collaborator

roym899 commented Oct 3, 2023

See title. I'd expect smaller font size for higher heading levels.

Additional context

rerun_py 0.9.0-alpha.6 [rustc 1.72.1 (d5c2e9c34 2023-09-13), LLVM 16.0.5] x86_64-unknown-linux-gnu bde24df, built 2023-10-02T12:51:19Z
@roym899 roym899 added 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team labels Oct 3, 2023
@emilk emilk added the ui concerns graphical user interface label Oct 3, 2023
@nikolausWest nikolausWest removed the 👀 needs triage This issue needs to be triaged by the Rerun team label Oct 3, 2023
@nikolausWest nikolausWest added this to the 0.10 Polish milestone Oct 3, 2023
@haritha208
Copy link

assign the issue to me,currently i am working on ui & ux

@nikolausWest
Copy link
Member

@haritha208: Do you know how to fix it? I believe it requires a fix in egui and/or egui_commonmark

@abey79
Copy link
Member

abey79 commented Oct 11, 2023

repro:

import rerun as rr

rr.init("md", spawn=True)

rr.log(
    "my_points",
    rr.TextDocument("""
# Heading level 1

## Heading level 2

### Heading level 3

#### Heading level 4

##### Heading level 5

###### Heading level 6

Body text
 """, media_type=rr.MediaType.MARKDOWN)
)

result:

image

I believe this might be due to some interaction between the way egui_commonmark sets up styling and our own re_ui customisations:
image

abey79 added a commit that referenced this issue Oct 11, 2023
@abey79
Work around #3612 by not using H1
c693673
@abey79 abey79 mentioned this issue Oct 11, 2023
Merged
4 tasks
abey79 added a commit that referenced this issue Oct 12, 2023
@abey79
Work around #3612 by not using H1
2475857
abey79 added a commit that referenced this issue Oct 17, 2023
@abey79 @emilk
Add basic support for in-app "Quick Start" guides (#3813)
3c912be 
### What

This PR lays the basis for in-app "Quick Start" guides.

After a failed attempt to use `re_sdk` from `re_viewer` (can't target
wasm), this PR builds on recent `StoreDb` API improvements to create
"quick start" recordings from scratch.

This involves:
- adding a nice `StoreDb::from_info_and_rows()` helper function
- adding `SystemCommand::LoadStoreDb(StoreDb)`
- adding `StoreSource::Viewer` (for recordings generated from the viewer
itself)
- some helper functions in `welcome_page.rs`

This PR also introduces a draft for the (native-only) Python and Rust
Quick Starts, and placeholder for the other languages.

To address (in follow-up PR):
- markdown formatting issue where H1 appears smaller than H2 (current
work around: skip on using H1)
  - #3612
- specialise Quick Start for non-server Viewers
  - #3871 
- write Quick Start for C++:
  - #3870 
- markdown formatting issue:
  - lampsitter/egui_commonmark#19

<img width="1315" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/232b4a79-7917-4978-95d1-94474142da94">

* Fixes #3095


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3813) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3813)
- [Docs
preview](https://rerun.io/preview/9c7ebbf37a890b5d09941102a4d7c3a35f53f277/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/9c7ebbf37a890b5d09941102a4d7c3a35f53f277/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@emilk emilk added the egui Requires egui/eframe work label Nov 7, 2023
@abey79
Copy link
Member

abey79 commented Nov 7, 2023

This should be easily fixable in the SpaceView's ui() function (reset some styling).

@abey79 abey79 mentioned this issue Nov 7, 2023
Merged
@abey79
Copy link
Member

abey79 commented Nov 7, 2023

Fixed by lampsitter/egui_commonmark#20

@abey79 abey79 mentioned this issue Nov 8, 2023
Merged
4 tasks
abey79 added a commit that referenced this issue Nov 8, 2023
@abey79
Fix markdown heading size (#4178)
a586ae4 
### What

- Take advantage of
lampsitter/egui_commonmark#20 to use "correct"
headings in in-app quick start guides.
- Bump egui_commonmark to 0.9.2 which includes the PR above
- Fixes #3612

<img width="1305" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/a4befe22-2675-4a8f-a5ca-38cec3141b13">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4178) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4178)
- [Docs
preview](https://rerun.io/preview/85986f760b9d674ecb58917f1b77693f43d3c3bf/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/85986f760b9d674ecb58917f1b77693f43d3c3bf/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use egui Requires egui/eframe work ui concerns graphical user interface
Projects
None yet
Milestone
Triage
Development

Successfully merging a pull request may close this issue.

Fix header sizing issue rerun-io/egui_commonmark
Fix markdown heading size rerun-io/rerun
5 participants
@emilk @nikolausWest @roym899 @abey79 @haritha208