-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for in-app "Quick Start" guides #3813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed it to a draft because of the wasm-issue discussed in https://rerunio.slack.com/archives/C041NHU952S/p1697037259411659 |
emilk
reviewed
Oct 11, 2023
abey79
force-pushed
the
antoine/python-quick-start
branch
from
October 12, 2023 14:52
ea4e218
to
a7bf17d
Compare
emilk
requested changes
Oct 13, 2023
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
emilk
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but let's pull out the actual example code to a separate file so that we make sure it will always run properly!
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
emilk
reviewed
Oct 16, 2023
emilk
approved these changes
Oct 16, 2023
# Conflicts: # docs/code-examples/roundtrips.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR lays the basis for in-app "Quick Start" guides.
After a failed attempt to use
re_sdk
fromre_viewer
(can't target wasm), this PR builds on recentStoreDb
API improvements to create "quick start" recordings from scratch.This involves:
StoreDb::from_info_and_rows()
helper functionSystemCommand::LoadStoreDb(StoreDb)
StoreSource::Viewer
(for recordings generated from the viewer itself)welcome_page.rs
This PR also introduces a draft for the (native-only) Python and Rust Quick Starts, and placeholder for the other languages.
To address (in follow-up PR):
Checklist